Move settings into its own framework #5153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pronebird
force-pushed
the
extract-settings
branch
from
693aecf to
fc75c75
Compare
buggmagnet
approved these changes
Sep 20, 2023
There was a problem hiding this comment.
Reviewable status: 0 of 62 files reviewed, all discussions resolved
buggmagnet
force-pushed
the
extract-settings
branch
from
fc75c75 to
b637d52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves settings related types into
Settingsframework. This is the last piece of code that was injected directly into packet tunnel and main app targets. Not anymore.This change is